Merge tag 'for-linus-v3.10-rc3' of git://oss.sgi.com/xfs/xfs
[GitHub/mt8127/android_kernel_alcatel_ttab.git] / drivers / acpi / ec.c
CommitLineData
1da177e4 1/*
7c6db4e0 2 * ec.c - ACPI Embedded Controller Driver (v2.1)
1da177e4 3 *
7c6db4e0 4 * Copyright (C) 2006-2008 Alexey Starikovskiy <astarikovskiy@suse.de>
01f22462 5 * Copyright (C) 2006 Denis Sadykov <denis.m.sadykov@intel.com>
1da177e4
LT
6 * Copyright (C) 2004 Luming Yu <luming.yu@intel.com>
7 * Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
8 * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
9 *
10 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11 *
12 * This program is free software; you can redistribute it and/or modify
13 * it under the terms of the GNU General Public License as published by
14 * the Free Software Foundation; either version 2 of the License, or (at
15 * your option) any later version.
16 *
17 * This program is distributed in the hope that it will be useful, but
18 * WITHOUT ANY WARRANTY; without even the implied warranty of
19 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
20 * General Public License for more details.
21 *
22 * You should have received a copy of the GNU General Public License along
23 * with this program; if not, write to the Free Software Foundation, Inc.,
24 * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
25 *
26 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
27 */
28
7c6db4e0 29/* Uncomment next line to get verbose printout */
d772b3b3
MN
30/* #define DEBUG */
31
1da177e4
LT
32#include <linux/kernel.h>
33#include <linux/module.h>
34#include <linux/init.h>
35#include <linux/types.h>
36#include <linux/delay.h>
451566f4 37#include <linux/interrupt.h>
837012ed 38#include <linux/list.h>
7c6db4e0 39#include <linux/spinlock.h>
5a0e3ad6 40#include <linux/slab.h>
1da177e4
LT
41#include <asm/io.h>
42#include <acpi/acpi_bus.h>
43#include <acpi/acpi_drivers.h>
eb27cae8 44#include <linux/dmi.h>
1da177e4 45
1195a098
TR
46#include "internal.h"
47
1da177e4 48#define ACPI_EC_CLASS "embedded_controller"
1da177e4
LT
49#define ACPI_EC_DEVICE_NAME "Embedded Controller"
50#define ACPI_EC_FILE_INFO "info"
837012ed 51
1195a098 52#undef PREFIX
af3fd140 53#define PREFIX "ACPI: EC: "
4350933a 54
703959d4 55/* EC status register */
1da177e4
LT
56#define ACPI_EC_FLAG_OBF 0x01 /* Output buffer full */
57#define ACPI_EC_FLAG_IBF 0x02 /* Input buffer full */
451566f4 58#define ACPI_EC_FLAG_BURST 0x10 /* burst mode */
1da177e4 59#define ACPI_EC_FLAG_SCI 0x20 /* EC-SCI occurred */
4350933a 60
703959d4 61/* EC commands */
3261ff4d 62enum ec_command {
6ccedb10
AS
63 ACPI_EC_COMMAND_READ = 0x80,
64 ACPI_EC_COMMAND_WRITE = 0x81,
65 ACPI_EC_BURST_ENABLE = 0x82,
66 ACPI_EC_BURST_DISABLE = 0x83,
67 ACPI_EC_COMMAND_QUERY = 0x84,
3261ff4d 68};
837012ed 69
5c406412 70#define ACPI_EC_DELAY 500 /* Wait 500ms max. during EC ops */
703959d4 71#define ACPI_EC_UDELAY_GLK 1000 /* Wait 1ms max. to get global lock */
2a84cb98 72#define ACPI_EC_MSI_UDELAY 550 /* Wait 550us for MSI EC */
703959d4 73
080e412c 74enum {
080e412c 75 EC_FLAGS_QUERY_PENDING, /* Query is pending */
7c6db4e0 76 EC_FLAGS_GPE_STORM, /* GPE storm detected */
f6bb13aa 77 EC_FLAGS_HANDLERS_INSTALLED, /* Handlers for GPE and
7c6db4e0 78 * OpReg are installed */
fe955682 79 EC_FLAGS_BLOCKED, /* Transactions are blocked */
1da177e4 80};
6ffb221a 81
7a18e96d
TR
82/* ec.c is compiled in acpi namespace so this shows up as acpi.ec_delay param */
83static unsigned int ec_delay __read_mostly = ACPI_EC_DELAY;
84module_param(ec_delay, uint, 0644);
85MODULE_PARM_DESC(ec_delay, "Timeout(ms) waited until an EC command completes");
86
a520d52e
FT
87/*
88 * If the number of false interrupts per one transaction exceeds
89 * this threshold, will think there is a GPE storm happened and
90 * will disable the GPE for normal transaction.
91 */
92static unsigned int ec_storm_threshold __read_mostly = 8;
93module_param(ec_storm_threshold, uint, 0644);
94MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");
95
6ffb221a 96/* If we find an EC via the ECDT, we need to keep a ptr to its context */
d033879c 97/* External interfaces use first EC only, so remember */
837012ed
AS
98typedef int (*acpi_ec_query_func) (void *data);
99
100struct acpi_ec_query_handler {
101 struct list_head node;
102 acpi_ec_query_func func;
103 acpi_handle handle;
104 void *data;
105 u8 query_bit;
106};
107
8463200a 108struct transaction {
7c6db4e0
AS
109 const u8 *wdata;
110 u8 *rdata;
111 unsigned short irq_count;
8463200a 112 u8 command;
a2f93aea
AS
113 u8 wi;
114 u8 ri;
7c6db4e0
AS
115 u8 wlen;
116 u8 rlen;
dd15f8c4 117 bool done;
7c6db4e0
AS
118};
119
1195a098
TR
120struct acpi_ec *boot_ec, *first_ec;
121EXPORT_SYMBOL(first_ec);
703959d4 122
5423a0cb 123static int EC_FLAGS_MSI; /* Out-of-spec MSI controller */
0adf3c74 124static int EC_FLAGS_VALIDATE_ECDT; /* ASUStec ECDTs need to be validated */
478fa03b 125static int EC_FLAGS_SKIP_DSDT_SCAN; /* Not all BIOS survive early DSDT scan */
5423a0cb 126
1da177e4
LT
127/* --------------------------------------------------------------------------
128 Transaction Management
129 -------------------------------------------------------------------------- */
130
6ffb221a 131static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
1da177e4 132{
3ebe08a7 133 u8 x = inb(ec->command_addr);
86dae015 134 pr_debug(PREFIX "---> status = 0x%2.2x\n", x);
3ebe08a7 135 return x;
451566f4
DT
136}
137
6ffb221a 138static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
703959d4 139{
3ebe08a7 140 u8 x = inb(ec->data_addr);
86dae015 141 pr_debug(PREFIX "---> data = 0x%2.2x\n", x);
7c6db4e0 142 return x;
7c6db5e5
DS
143}
144
6ffb221a 145static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
45bea155 146{
86dae015 147 pr_debug(PREFIX "<--- command = 0x%2.2x\n", command);
6ffb221a 148 outb(command, ec->command_addr);
45bea155
LY
149}
150
6ffb221a 151static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
45bea155 152{
86dae015 153 pr_debug(PREFIX "<--- data = 0x%2.2x\n", data);
6ffb221a 154 outb(data, ec->data_addr);
703959d4 155}
45bea155 156
7c6db4e0 157static int ec_transaction_done(struct acpi_ec *ec)
6ffb221a 158{
7c6db4e0
AS
159 unsigned long flags;
160 int ret = 0;
f351d027 161 spin_lock_irqsave(&ec->lock, flags);
dd15f8c4 162 if (!ec->curr || ec->curr->done)
7c6db4e0 163 ret = 1;
f351d027 164 spin_unlock_irqrestore(&ec->lock, flags);
7c6db4e0 165 return ret;
45bea155 166}
451566f4 167
a2f93aea
AS
168static void start_transaction(struct acpi_ec *ec)
169{
170 ec->curr->irq_count = ec->curr->wi = ec->curr->ri = 0;
171 ec->curr->done = false;
172 acpi_ec_write_cmd(ec, ec->curr->command);
173}
174
2a84cb98 175static void advance_transaction(struct acpi_ec *ec, u8 status)
7c6db5e5 176{
7c6db4e0 177 unsigned long flags;
b76b51ba
FT
178 struct transaction *t = ec->curr;
179
f351d027 180 spin_lock_irqsave(&ec->lock, flags);
b76b51ba 181 if (!t)
7c6db4e0 182 goto unlock;
b76b51ba 183 if (t->wlen > t->wi) {
a2f93aea
AS
184 if ((status & ACPI_EC_FLAG_IBF) == 0)
185 acpi_ec_write_data(ec,
b76b51ba 186 t->wdata[t->wi++]);
a2f93aea 187 else
dd15f8c4 188 goto err;
b76b51ba 189 } else if (t->rlen > t->ri) {
7c6db4e0 190 if ((status & ACPI_EC_FLAG_OBF) == 1) {
b76b51ba
FT
191 t->rdata[t->ri++] = acpi_ec_read_data(ec);
192 if (t->rlen == t->ri)
193 t->done = true;
7c6db4e0 194 } else
dd15f8c4 195 goto err;
b76b51ba 196 } else if (t->wlen == t->wi &&
a2f93aea 197 (status & ACPI_EC_FLAG_IBF) == 0)
b76b51ba 198 t->done = true;
dd15f8c4
AS
199 goto unlock;
200err:
a3cd8d27
FT
201 /*
202 * If SCI bit is set, then don't think it's a false IRQ
203 * otherwise will take a not handled IRQ as a false one.
204 */
205 if (in_interrupt() && !(status & ACPI_EC_FLAG_SCI))
b76b51ba 206 ++t->irq_count;
a3cd8d27 207
7c6db4e0 208unlock:
f351d027 209 spin_unlock_irqrestore(&ec->lock, flags);
845625cd 210}
03d1d99c 211
a62e8f19 212static int acpi_ec_sync_query(struct acpi_ec *ec);
7c6db4e0 213
a62e8f19 214static int ec_check_sci_sync(struct acpi_ec *ec, u8 state)
7c6db5e5 215{
7c6db4e0
AS
216 if (state & ACPI_EC_FLAG_SCI) {
217 if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags))
a62e8f19 218 return acpi_ec_sync_query(ec);
7c6db4e0
AS
219 }
220 return 0;
221}
222
223static int ec_poll(struct acpi_ec *ec)
224{
2a84cb98 225 unsigned long flags;
28fe5c82 226 int repeat = 5; /* number of command restarts */
2a84cb98
AS
227 while (repeat--) {
228 unsigned long delay = jiffies +
7a18e96d 229 msecs_to_jiffies(ec_delay);
2a84cb98
AS
230 do {
231 /* don't sleep with disabled interrupts */
232 if (EC_FLAGS_MSI || irqs_disabled()) {
233 udelay(ACPI_EC_MSI_UDELAY);
234 if (ec_transaction_done(ec))
235 return 0;
236 } else {
237 if (wait_event_timeout(ec->wait,
238 ec_transaction_done(ec),
239 msecs_to_jiffies(1)))
240 return 0;
241 }
242 advance_transaction(ec, acpi_ec_read_status(ec));
243 } while (time_before(jiffies, delay));
2a84cb98 244 pr_debug(PREFIX "controller reset, restart transaction\n");
f351d027 245 spin_lock_irqsave(&ec->lock, flags);
2a84cb98 246 start_transaction(ec);
f351d027 247 spin_unlock_irqrestore(&ec->lock, flags);
af3fd140 248 }
b77d81b2 249 return -ETIME;
1da177e4
LT
250}
251
8463200a 252static int acpi_ec_transaction_unlocked(struct acpi_ec *ec,
2a84cb98 253 struct transaction *t)
45bea155 254{
7c6db4e0 255 unsigned long tmp;
7c6db4e0 256 int ret = 0;
5423a0cb 257 if (EC_FLAGS_MSI)
2a84cb98 258 udelay(ACPI_EC_MSI_UDELAY);
7c6db4e0 259 /* start transaction */
f351d027 260 spin_lock_irqsave(&ec->lock, tmp);
7c6db4e0 261 /* following two actions should be kept atomic */
8463200a 262 ec->curr = t;
a2f93aea 263 start_transaction(ec);
8463200a 264 if (ec->curr->command == ACPI_EC_COMMAND_QUERY)
080e412c 265 clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
f351d027 266 spin_unlock_irqrestore(&ec->lock, tmp);
2a84cb98 267 ret = ec_poll(ec);
f351d027 268 spin_lock_irqsave(&ec->lock, tmp);
8463200a 269 ec->curr = NULL;
f351d027 270 spin_unlock_irqrestore(&ec->lock, tmp);
7c6db4e0
AS
271 return ret;
272}
273
274static int ec_check_ibf0(struct acpi_ec *ec)
275{
276 u8 status = acpi_ec_read_status(ec);
277 return (status & ACPI_EC_FLAG_IBF) == 0;
45bea155
LY
278}
279
c0ff1772
AS
280static int ec_wait_ibf0(struct acpi_ec *ec)
281{
7a18e96d 282 unsigned long delay = jiffies + msecs_to_jiffies(ec_delay);
c0ff1772 283 /* interrupt wait manually if GPE mode is not active */
c0ff1772 284 while (time_before(jiffies, delay))
2a84cb98
AS
285 if (wait_event_timeout(ec->wait, ec_check_ibf0(ec),
286 msecs_to_jiffies(1)))
c0ff1772
AS
287 return 0;
288 return -ETIME;
45bea155
LY
289}
290
2a84cb98 291static int acpi_ec_transaction(struct acpi_ec *ec, struct transaction *t)
1da177e4 292{
d7a76e4c 293 int status;
50526df6 294 u32 glk;
8463200a 295 if (!ec || (!t) || (t->wlen && !t->wdata) || (t->rlen && !t->rdata))
d550d98d 296 return -EINVAL;
8463200a
AS
297 if (t->rdata)
298 memset(t->rdata, 0, t->rlen);
f351d027 299 mutex_lock(&ec->mutex);
fe955682 300 if (test_bit(EC_FLAGS_BLOCKED, &ec->flags)) {
f6bb13aa
RW
301 status = -EINVAL;
302 goto unlock;
303 }
703959d4 304 if (ec->global_lock) {
1da177e4 305 status = acpi_acquire_global_lock(ACPI_EC_UDELAY_GLK, &glk);
c24e912b 306 if (ACPI_FAILURE(status)) {
7c6db4e0
AS
307 status = -ENODEV;
308 goto unlock;
c24e912b 309 }
1da177e4 310 }
c0ff1772 311 if (ec_wait_ibf0(ec)) {
3ebe08a7
MN
312 pr_err(PREFIX "input buffer is not empty, "
313 "aborting transaction\n");
7c6db4e0 314 status = -ETIME;
451566f4 315 goto end;
716e084e 316 }
b76b51ba
FT
317 pr_debug(PREFIX "transaction start (cmd=0x%02x, addr=0x%02x)\n",
318 t->command, t->wdata ? t->wdata[0] : 0);
a62e8f19
AS
319 /* disable GPE during transaction if storm is detected */
320 if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
3784730b
RW
321 /* It has to be disabled, so that it doesn't trigger. */
322 acpi_disable_gpe(NULL, ec->gpe);
a62e8f19
AS
323 }
324
2a84cb98 325 status = acpi_ec_transaction_unlocked(ec, t);
a62e8f19
AS
326
327 /* check if we received SCI during transaction */
328 ec_check_sci_sync(ec, acpi_ec_read_status(ec));
329 if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
54070101 330 msleep(1);
3784730b
RW
331 /* It is safe to enable the GPE outside of the transaction. */
332 acpi_enable_gpe(NULL, ec->gpe);
a520d52e 333 } else if (t->irq_count > ec_storm_threshold) {
b76b51ba
FT
334 pr_info(PREFIX "GPE storm detected(%d GPEs), "
335 "transactions will use polling mode\n",
336 t->irq_count);
a62e8f19
AS
337 set_bit(EC_FLAGS_GPE_STORM, &ec->flags);
338 }
54070101 339 pr_debug(PREFIX "transaction end\n");
7c6db4e0 340end:
703959d4 341 if (ec->global_lock)
1da177e4 342 acpi_release_global_lock(glk);
7c6db4e0 343unlock:
f351d027 344 mutex_unlock(&ec->mutex);
d550d98d 345 return status;
1da177e4
LT
346}
347
8a383ef0 348static int acpi_ec_burst_enable(struct acpi_ec *ec)
c45aac43
AS
349{
350 u8 d;
8463200a
AS
351 struct transaction t = {.command = ACPI_EC_BURST_ENABLE,
352 .wdata = NULL, .rdata = &d,
353 .wlen = 0, .rlen = 1};
354
2a84cb98 355 return acpi_ec_transaction(ec, &t);
c45aac43
AS
356}
357
8a383ef0 358static int acpi_ec_burst_disable(struct acpi_ec *ec)
c45aac43 359{
8463200a
AS
360 struct transaction t = {.command = ACPI_EC_BURST_DISABLE,
361 .wdata = NULL, .rdata = NULL,
362 .wlen = 0, .rlen = 0};
363
7c6db4e0 364 return (acpi_ec_read_status(ec) & ACPI_EC_FLAG_BURST) ?
2a84cb98 365 acpi_ec_transaction(ec, &t) : 0;
c45aac43
AS
366}
367
6ccedb10 368static int acpi_ec_read(struct acpi_ec *ec, u8 address, u8 * data)
3576cf61
DS
369{
370 int result;
371 u8 d;
8463200a
AS
372 struct transaction t = {.command = ACPI_EC_COMMAND_READ,
373 .wdata = &address, .rdata = &d,
374 .wlen = 1, .rlen = 1};
3576cf61 375
2a84cb98 376 result = acpi_ec_transaction(ec, &t);
3576cf61
DS
377 *data = d;
378 return result;
379}
6ffb221a 380
3576cf61
DS
381static int acpi_ec_write(struct acpi_ec *ec, u8 address, u8 data)
382{
6ccedb10 383 u8 wdata[2] = { address, data };
8463200a
AS
384 struct transaction t = {.command = ACPI_EC_COMMAND_WRITE,
385 .wdata = wdata, .rdata = NULL,
386 .wlen = 2, .rlen = 0};
387
2a84cb98 388 return acpi_ec_transaction(ec, &t);
3576cf61
DS
389}
390
1da177e4
LT
391/*
392 * Externally callable EC access functions. For now, assume 1 EC only
393 */
c45aac43
AS
394int ec_burst_enable(void)
395{
c45aac43
AS
396 if (!first_ec)
397 return -ENODEV;
d033879c 398 return acpi_ec_burst_enable(first_ec);
c45aac43
AS
399}
400
401EXPORT_SYMBOL(ec_burst_enable);
402
403int ec_burst_disable(void)
404{
c45aac43
AS
405 if (!first_ec)
406 return -ENODEV;
d033879c 407 return acpi_ec_burst_disable(first_ec);
c45aac43
AS
408}
409
410EXPORT_SYMBOL(ec_burst_disable);
411
b76b51ba 412int ec_read(u8 addr, u8 *val)
1da177e4 413{
1da177e4 414 int err;
6ffb221a 415 u8 temp_data;
1da177e4
LT
416
417 if (!first_ec)
418 return -ENODEV;
419
d033879c 420 err = acpi_ec_read(first_ec, addr, &temp_data);
1da177e4
LT
421
422 if (!err) {
423 *val = temp_data;
424 return 0;
50526df6 425 } else
1da177e4
LT
426 return err;
427}
50526df6 428
1da177e4
LT
429EXPORT_SYMBOL(ec_read);
430
50526df6 431int ec_write(u8 addr, u8 val)
1da177e4 432{
1da177e4
LT
433 int err;
434
435 if (!first_ec)
436 return -ENODEV;
437
d033879c 438 err = acpi_ec_write(first_ec, addr, val);
1da177e4
LT
439
440 return err;
441}
50526df6 442
1da177e4
LT
443EXPORT_SYMBOL(ec_write);
444
616362de 445int ec_transaction(u8 command,
9e197219 446 const u8 * wdata, unsigned wdata_len,
1cb7b1e0 447 u8 * rdata, unsigned rdata_len)
45bea155 448{
8463200a
AS
449 struct transaction t = {.command = command,
450 .wdata = wdata, .rdata = rdata,
451 .wlen = wdata_len, .rlen = rdata_len};
d7a76e4c
LP
452 if (!first_ec)
453 return -ENODEV;
45bea155 454
2a84cb98 455 return acpi_ec_transaction(first_ec, &t);
45bea155 456}
1da177e4 457
ab9e43c6
LP
458EXPORT_SYMBOL(ec_transaction);
459
3e2abc5a
SF
460/* Get the handle to the EC device */
461acpi_handle ec_get_handle(void)
462{
463 if (!first_ec)
464 return NULL;
465 return first_ec->handle;
466}
467
468EXPORT_SYMBOL(ec_get_handle);
469
fe955682 470void acpi_ec_block_transactions(void)
f6bb13aa
RW
471{
472 struct acpi_ec *ec = first_ec;
473
474 if (!ec)
475 return;
476
f351d027 477 mutex_lock(&ec->mutex);
f6bb13aa 478 /* Prevent transactions from being carried out */
fe955682 479 set_bit(EC_FLAGS_BLOCKED, &ec->flags);
f351d027 480 mutex_unlock(&ec->mutex);
f6bb13aa
RW
481}
482
fe955682 483void acpi_ec_unblock_transactions(void)
f6bb13aa
RW
484{
485 struct acpi_ec *ec = first_ec;
486
487 if (!ec)
488 return;
489
f351d027 490 mutex_lock(&ec->mutex);
f6bb13aa 491 /* Allow transactions to be carried out again */
fe955682 492 clear_bit(EC_FLAGS_BLOCKED, &ec->flags);
f351d027 493 mutex_unlock(&ec->mutex);
f6bb13aa
RW
494}
495
fe955682 496void acpi_ec_unblock_transactions_early(void)
d5a64513
RW
497{
498 /*
499 * Allow transactions to happen again (this function is called from
500 * atomic context during wakeup, so we don't need to acquire the mutex).
501 */
502 if (first_ec)
fe955682 503 clear_bit(EC_FLAGS_BLOCKED, &first_ec->flags);
d5a64513
RW
504}
505
a62e8f19 506static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data)
3576cf61
DS
507{
508 int result;
6ccedb10 509 u8 d;
8463200a
AS
510 struct transaction t = {.command = ACPI_EC_COMMAND_QUERY,
511 .wdata = NULL, .rdata = &d,
512 .wlen = 0, .rlen = 1};
6ccedb10
AS
513 if (!ec || !data)
514 return -EINVAL;
6ccedb10
AS
515 /*
516 * Query the EC to find out which _Qxx method we need to evaluate.
517 * Note that successful completion of the query causes the ACPI_EC_SCI
518 * bit to be cleared (and thus clearing the interrupt source).
519 */
a62e8f19 520 result = acpi_ec_transaction_unlocked(ec, &t);
6ccedb10
AS
521 if (result)
522 return result;
6ccedb10
AS
523 if (!d)
524 return -ENODATA;
6ccedb10
AS
525 *data = d;
526 return 0;
1da177e4
LT
527}
528
1da177e4
LT
529/* --------------------------------------------------------------------------
530 Event Management
531 -------------------------------------------------------------------------- */
837012ed
AS
532int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit,
533 acpi_handle handle, acpi_ec_query_func func,
534 void *data)
535{
536 struct acpi_ec_query_handler *handler =
537 kzalloc(sizeof(struct acpi_ec_query_handler), GFP_KERNEL);
538 if (!handler)
539 return -ENOMEM;
540
541 handler->query_bit = query_bit;
542 handler->handle = handle;
543 handler->func = func;
544 handler->data = data;
f351d027 545 mutex_lock(&ec->mutex);
30c08574 546 list_add(&handler->node, &ec->list);
f351d027 547 mutex_unlock(&ec->mutex);
837012ed
AS
548 return 0;
549}
550
551EXPORT_SYMBOL_GPL(acpi_ec_add_query_handler);
552
553void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit)
554{
1544fdbc 555 struct acpi_ec_query_handler *handler, *tmp;
f351d027 556 mutex_lock(&ec->mutex);
1544fdbc 557 list_for_each_entry_safe(handler, tmp, &ec->list, node) {
837012ed
AS
558 if (query_bit == handler->query_bit) {
559 list_del(&handler->node);
560 kfree(handler);
837012ed
AS
561 }
562 }
f351d027 563 mutex_unlock(&ec->mutex);
837012ed
AS
564}
565
566EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler);
1da177e4 567
a62e8f19 568static void acpi_ec_run(void *cxt)
45bea155 569{
a62e8f19
AS
570 struct acpi_ec_query_handler *handler = cxt;
571 if (!handler)
e41334c0 572 return;
a62e8f19
AS
573 pr_debug(PREFIX "start query execution\n");
574 if (handler->func)
575 handler->func(handler->data);
576 else if (handler->handle)
577 acpi_evaluate_object(handler->handle, NULL, NULL, NULL);
578 pr_debug(PREFIX "stop query execution\n");
579 kfree(handler);
580}
581
582static int acpi_ec_sync_query(struct acpi_ec *ec)
583{
584 u8 value = 0;
585 int status;
586 struct acpi_ec_query_handler *handler, *copy;
587 if ((status = acpi_ec_query_unlocked(ec, &value)))
588 return status;
837012ed
AS
589 list_for_each_entry(handler, &ec->list, node) {
590 if (value == handler->query_bit) {
591 /* have custom handler for this bit */
a62e8f19
AS
592 copy = kmalloc(sizeof(*handler), GFP_KERNEL);
593 if (!copy)
594 return -ENOMEM;
595 memcpy(copy, handler, sizeof(*copy));
596 pr_debug(PREFIX "push query execution (0x%2x) on queue\n", value);
f5347867
AS
597 return acpi_os_execute((copy->func) ?
598 OSL_NOTIFY_HANDLER : OSL_GPE_HANDLER,
a62e8f19 599 acpi_ec_run, copy);
837012ed
AS
600 }
601 }
a62e8f19
AS
602 return 0;
603}
604
605static void acpi_ec_gpe_query(void *ec_cxt)
606{
607 struct acpi_ec *ec = ec_cxt;
608 if (!ec)
609 return;
f351d027 610 mutex_lock(&ec->mutex);
a62e8f19 611 acpi_ec_sync_query(ec);
f351d027 612 mutex_unlock(&ec->mutex);
45bea155 613}
1da177e4 614
a62e8f19
AS
615static int ec_check_sci(struct acpi_ec *ec, u8 state)
616{
617 if (state & ACPI_EC_FLAG_SCI) {
618 if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags)) {
619 pr_debug(PREFIX "push gpe query to the queue\n");
620 return acpi_os_execute(OSL_NOTIFY_HANDLER,
621 acpi_ec_gpe_query, ec);
622 }
623 }
624 return 0;
625}
626
8b6cd8ad
LM
627static u32 acpi_ec_gpe_handler(acpi_handle gpe_device,
628 u32 gpe_number, void *data)
1da177e4 629{
3d02b90b 630 struct acpi_ec *ec = data;
b76b51ba 631 u8 status = acpi_ec_read_status(ec);
00eb43a1 632
b76b51ba 633 pr_debug(PREFIX "~~~> interrupt, status:0x%02x\n", status);
7c6db4e0 634
b76b51ba 635 advance_transaction(ec, status);
a62e8f19
AS
636 if (ec_transaction_done(ec) &&
637 (acpi_ec_read_status(ec) & ACPI_EC_FLAG_IBF) == 0) {
2a84cb98 638 wake_up(&ec->wait);
a62e8f19
AS
639 ec_check_sci(ec, acpi_ec_read_status(ec));
640 }
bba63a29 641 return ACPI_INTERRUPT_HANDLED | ACPI_REENABLE_GPE;
845625cd
AS
642}
643
1da177e4
LT
644/* --------------------------------------------------------------------------
645 Address Space Management
646 -------------------------------------------------------------------------- */
647
1da177e4 648static acpi_status
5b7734b4 649acpi_ec_space_handler(u32 function, acpi_physical_address address,
dadf28a1 650 u32 bits, u64 *value64,
50526df6 651 void *handler_context, void *region_context)
1da177e4 652{
3d02b90b 653 struct acpi_ec *ec = handler_context;
dadf28a1
AS
654 int result = 0, i, bytes = bits / 8;
655 u8 *value = (u8 *)value64;
1da177e4 656
1da177e4 657 if ((address > 0xFF) || !value || !handler_context)
d550d98d 658 return AE_BAD_PARAMETER;
1da177e4 659
5b7734b4 660 if (function != ACPI_READ && function != ACPI_WRITE)
d550d98d 661 return AE_BAD_PARAMETER;
1da177e4 662
dadf28a1 663 if (EC_FLAGS_MSI || bits > 8)
6a63b06f 664 acpi_ec_burst_enable(ec);
b3b233c7 665
dadf28a1
AS
666 for (i = 0; i < bytes; ++i, ++address, ++value)
667 result = (function == ACPI_READ) ?
668 acpi_ec_read(ec, address, value) :
669 acpi_ec_write(ec, address, *value);
1da177e4 670
dadf28a1 671 if (EC_FLAGS_MSI || bits > 8)
6a63b06f 672 acpi_ec_burst_disable(ec);
b3b233c7 673
1da177e4
LT
674 switch (result) {
675 case -EINVAL:
d550d98d 676 return AE_BAD_PARAMETER;
1da177e4
LT
677 break;
678 case -ENODEV:
d550d98d 679 return AE_NOT_FOUND;
1da177e4
LT
680 break;
681 case -ETIME:
d550d98d 682 return AE_TIME;
1da177e4
LT
683 break;
684 default:
d550d98d 685 return AE_OK;
1da177e4 686 }
1da177e4
LT
687}
688
1da177e4
LT
689/* --------------------------------------------------------------------------
690 Driver Interface
691 -------------------------------------------------------------------------- */
c0900c35
AS
692static acpi_status
693ec_parse_io_ports(struct acpi_resource *resource, void *context);
694
c0900c35
AS
695static struct acpi_ec *make_acpi_ec(void)
696{
697 struct acpi_ec *ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
698 if (!ec)
699 return NULL;
080e412c 700 ec->flags = 1 << EC_FLAGS_QUERY_PENDING;
f351d027 701 mutex_init(&ec->mutex);
c0900c35 702 init_waitqueue_head(&ec->wait);
837012ed 703 INIT_LIST_HEAD(&ec->list);
f351d027 704 spin_lock_init(&ec->lock);
c0900c35
AS
705 return ec;
706}
837012ed 707
c019b193
AS
708static acpi_status
709acpi_ec_register_query_methods(acpi_handle handle, u32 level,
710 void *context, void **return_value)
711{
0175d562
LM
712 char node_name[5];
713 struct acpi_buffer buffer = { sizeof(node_name), node_name };
c019b193
AS
714 struct acpi_ec *ec = context;
715 int value = 0;
0175d562
LM
716 acpi_status status;
717
718 status = acpi_get_name(handle, ACPI_SINGLE_NAME, &buffer);
719
720 if (ACPI_SUCCESS(status) && sscanf(node_name, "_Q%x", &value) == 1) {
c019b193
AS
721 acpi_ec_add_query_handler(ec, value, handle, NULL, NULL);
722 }
723 return AE_OK;
724}
725
cd8c93a4
AS
726static acpi_status
727ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
837012ed 728{
cd8c93a4 729 acpi_status status;
d21cf3c1 730 unsigned long long tmp = 0;
cd8c93a4
AS
731
732 struct acpi_ec *ec = context;
a5032bfd
AS
733
734 /* clear addr values, ec_parse_io_ports depend on it */
735 ec->command_addr = ec->data_addr = 0;
736
cd8c93a4
AS
737 status = acpi_walk_resources(handle, METHOD_NAME__CRS,
738 ec_parse_io_ports, ec);
739 if (ACPI_FAILURE(status))
740 return status;
837012ed
AS
741
742 /* Get GPE bit assignment (EC events). */
743 /* TODO: Add support for _GPE returning a package */
27663c58 744 status = acpi_evaluate_integer(handle, "_GPE", NULL, &tmp);
cd8c93a4
AS
745 if (ACPI_FAILURE(status))
746 return status;
27663c58 747 ec->gpe = tmp;
837012ed 748 /* Use the global lock for all EC transactions? */
d21cf3c1 749 tmp = 0;
27663c58
MW
750 acpi_evaluate_integer(handle, "_GLK", NULL, &tmp);
751 ec->global_lock = tmp;
837012ed 752 ec->handle = handle;
cd8c93a4 753 return AE_CTRL_TERMINATE;
837012ed
AS
754}
755
5efc5476
BH
756static int ec_install_handlers(struct acpi_ec *ec)
757{
758 acpi_status status;
759 if (test_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags))
760 return 0;
761 status = acpi_install_gpe_handler(NULL, ec->gpe,
762 ACPI_GPE_EDGE_TRIGGERED,
763 &acpi_ec_gpe_handler, ec);
764 if (ACPI_FAILURE(status))
765 return -ENODEV;
9630bdd9 766
a44061aa 767 acpi_enable_gpe(NULL, ec->gpe);
5efc5476
BH
768 status = acpi_install_address_space_handler(ec->handle,
769 ACPI_ADR_SPACE_EC,
770 &acpi_ec_space_handler,
771 NULL, ec);
772 if (ACPI_FAILURE(status)) {
773 if (status == AE_NOT_FOUND) {
774 /*
775 * Maybe OS fails in evaluating the _REG object.
776 * The AE_NOT_FOUND error will be ignored and OS
777 * continue to initialize EC.
778 */
779 printk(KERN_ERR "Fail in evaluating the _REG object"
780 " of EC device. Broken bios is suspected.\n");
781 } else {
782 acpi_remove_gpe_handler(NULL, ec->gpe,
783 &acpi_ec_gpe_handler);
a44061aa 784 acpi_disable_gpe(NULL, ec->gpe);
5efc5476
BH
785 return -ENODEV;
786 }
787 }
788
789 set_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
790 return 0;
791}
792
4c611060
AS
793static void ec_remove_handlers(struct acpi_ec *ec)
794{
a44061aa 795 acpi_disable_gpe(NULL, ec->gpe);
4c611060
AS
796 if (ACPI_FAILURE(acpi_remove_address_space_handler(ec->handle,
797 ACPI_ADR_SPACE_EC, &acpi_ec_space_handler)))
3ebe08a7 798 pr_err(PREFIX "failed to remove space handler\n");
4c611060
AS
799 if (ACPI_FAILURE(acpi_remove_gpe_handler(NULL, ec->gpe,
800 &acpi_ec_gpe_handler)))
3ebe08a7 801 pr_err(PREFIX "failed to remove gpe handler\n");
7c6db4e0 802 clear_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
4c611060
AS
803}
804
703959d4 805static int acpi_ec_add(struct acpi_device *device)
1da177e4 806{
703959d4 807 struct acpi_ec *ec = NULL;
d02be047 808 int ret;
45bea155 809
c0900c35
AS
810 strcpy(acpi_device_name(device), ACPI_EC_DEVICE_NAME);
811 strcpy(acpi_device_class(device), ACPI_EC_CLASS);
812
4c611060 813 /* Check for boot EC */
ce52ddf5
AS
814 if (boot_ec &&
815 (boot_ec->handle == device->handle ||
816 boot_ec->handle == ACPI_ROOT_OBJECT)) {
817 ec = boot_ec;
818 boot_ec = NULL;
819 } else {
820 ec = make_acpi_ec();
821 if (!ec)
822 return -ENOMEM;
a5032bfd
AS
823 }
824 if (ec_parse_device(device->handle, 0, ec, NULL) !=
825 AE_CTRL_TERMINATE) {
ce52ddf5
AS
826 kfree(ec);
827 return -EINVAL;
4c611060
AS
828 }
829
ce52ddf5
AS
830 /* Find and register all query methods */
831 acpi_walk_namespace(ACPI_TYPE_METHOD, ec->handle, 1,
2263576c 832 acpi_ec_register_query_methods, NULL, ec, NULL);
ce52ddf5 833
4c611060
AS
834 if (!first_ec)
835 first_ec = ec;
db89b4f0 836 device->driver_data = ec;
de4f1046 837
d6795fe3
AK
838 ret = !!request_region(ec->data_addr, 1, "EC data");
839 WARN(!ret, "Could not request EC data io port 0x%lx", ec->data_addr);
840 ret = !!request_region(ec->command_addr, 1, "EC cmd");
841 WARN(!ret, "Could not request EC cmd io port 0x%lx", ec->command_addr);
de4f1046 842
3ebe08a7 843 pr_info(PREFIX "GPE = 0x%lx, I/O: command/status = 0x%lx, data = 0x%lx\n",
4c611060 844 ec->gpe, ec->command_addr, ec->data_addr);
5efc5476
BH
845
846 ret = ec_install_handlers(ec);
847
848 /* EC is fully operational, allow queries */
849 clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
850 return ret;
1da177e4
LT
851}
852
51fac838 853static int acpi_ec_remove(struct acpi_device *device)
1da177e4 854{
01f22462 855 struct acpi_ec *ec;
07ddf768 856 struct acpi_ec_query_handler *handler, *tmp;
1da177e4 857
1da177e4 858 if (!device)
d550d98d 859 return -EINVAL;
1da177e4
LT
860
861 ec = acpi_driver_data(device);
cf745ec7 862 ec_remove_handlers(ec);
f351d027 863 mutex_lock(&ec->mutex);
07ddf768 864 list_for_each_entry_safe(handler, tmp, &ec->list, node) {
837012ed
AS
865 list_del(&handler->node);
866 kfree(handler);
867 }
f351d027 868 mutex_unlock(&ec->mutex);
de4f1046
TR
869 release_region(ec->data_addr, 1);
870 release_region(ec->command_addr, 1);
db89b4f0 871 device->driver_data = NULL;
d033879c 872 if (ec == first_ec)
c0900c35 873 first_ec = NULL;
4c611060 874 kfree(ec);
d550d98d 875 return 0;
1da177e4
LT
876}
877
1da177e4 878static acpi_status
c0900c35 879ec_parse_io_ports(struct acpi_resource *resource, void *context)
1da177e4 880{
3d02b90b 881 struct acpi_ec *ec = context;
1da177e4 882
01f22462 883 if (resource->type != ACPI_RESOURCE_TYPE_IO)
1da177e4 884 return AE_OK;
1da177e4
LT
885
886 /*
887 * The first address region returned is the data port, and
888 * the second address region returned is the status/command
889 * port.
890 */
de4f1046 891 if (ec->data_addr == 0)
6ffb221a 892 ec->data_addr = resource->data.io.minimum;
de4f1046 893 else if (ec->command_addr == 0)
6ffb221a 894 ec->command_addr = resource->data.io.minimum;
01f22462 895 else
1da177e4 896 return AE_CTRL_TERMINATE;
1da177e4 897
1da177e4
LT
898 return AE_OK;
899}
900
c04209a7
AS
901int __init acpi_boot_ec_enable(void)
902{
7c6db4e0 903 if (!boot_ec || test_bit(EC_FLAGS_HANDLERS_INSTALLED, &boot_ec->flags))
c04209a7
AS
904 return 0;
905 if (!ec_install_handlers(boot_ec)) {
906 first_ec = boot_ec;
907 return 0;
908 }
909 return -EFAULT;
910}
911
223883b7
AS
912static const struct acpi_device_id ec_device_ids[] = {
913 {"PNP0C09", 0},
914 {"", 0},
915};
916
478fa03b
AS
917/* Some BIOS do not survive early DSDT scan, skip it */
918static int ec_skip_dsdt_scan(const struct dmi_system_id *id)
919{
920 EC_FLAGS_SKIP_DSDT_SCAN = 1;
921 return 0;
922}
923
0adf3c74
AS
924/* ASUStek often supplies us with broken ECDT, validate it */
925static int ec_validate_ecdt(const struct dmi_system_id *id)
926{
927 EC_FLAGS_VALIDATE_ECDT = 1;
928 return 0;
929}
930
931/* MSI EC needs special treatment, enable it */
932static int ec_flag_msi(const struct dmi_system_id *id)
933{
55b313f2 934 printk(KERN_DEBUG PREFIX "Detected MSI hardware, enabling workarounds.\n");
0adf3c74
AS
935 EC_FLAGS_MSI = 1;
936 EC_FLAGS_VALIDATE_ECDT = 1;
937 return 0;
938}
939
67bfa9b6
FT
940/*
941 * Clevo M720 notebook actually works ok with IRQ mode, if we lifted
942 * the GPE storm threshold back to 20
943 */
944static int ec_enlarge_storm_threshold(const struct dmi_system_id *id)
945{
946 pr_debug("Setting the EC GPE storm threshold to 20\n");
947 ec_storm_threshold = 20;
948 return 0;
949}
950
0adf3c74 951static struct dmi_system_id __initdata ec_dmi_table[] = {
478fa03b
AS
952 {
953 ec_skip_dsdt_scan, "Compal JFL92", {
954 DMI_MATCH(DMI_BIOS_VENDOR, "COMPAL"),
955 DMI_MATCH(DMI_BOARD_NAME, "JFL92") }, NULL},
0adf3c74
AS
956 {
957 ec_flag_msi, "MSI hardware", {
55b313f2
AS
958 DMI_MATCH(DMI_BIOS_VENDOR, "Micro-Star")}, NULL},
959 {
960 ec_flag_msi, "MSI hardware", {
961 DMI_MATCH(DMI_SYS_VENDOR, "Micro-Star")}, NULL},
962 {
963 ec_flag_msi, "MSI hardware", {
964 DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-Star")}, NULL},
0adf3c74 965 {
a5dc4f89
AS
966 ec_flag_msi, "MSI hardware", {
967 DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-STAR")}, NULL},
968 {
534bc4e3
ZR
969 ec_flag_msi, "Quanta hardware", {
970 DMI_MATCH(DMI_SYS_VENDOR, "Quanta"),
971 DMI_MATCH(DMI_PRODUCT_NAME, "TW8/SW8/DW8"),}, NULL},
972 {
973 ec_flag_msi, "Quanta hardware", {
974 DMI_MATCH(DMI_SYS_VENDOR, "Quanta"),
975 DMI_MATCH(DMI_PRODUCT_NAME, "TW9/SW9"),}, NULL},
976 {
0adf3c74
AS
977 ec_validate_ecdt, "ASUS hardware", {
978 DMI_MATCH(DMI_BIOS_VENDOR, "ASUS") }, NULL},
af986d10
PC
979 {
980 ec_validate_ecdt, "ASUS hardware", {
981 DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer Inc.") }, NULL},
67bfa9b6
FT
982 {
983 ec_enlarge_storm_threshold, "CLEVO hardware", {
984 DMI_MATCH(DMI_SYS_VENDOR, "CLEVO Co."),
985 DMI_MATCH(DMI_PRODUCT_NAME, "M720T/M730T"),}, NULL},
0adf3c74
AS
986 {},
987};
988
c0900c35
AS
989int __init acpi_ec_ecdt_probe(void)
990{
c0900c35 991 acpi_status status;
c6cb0e87 992 struct acpi_ec *saved_ec = NULL;
50526df6 993 struct acpi_table_ecdt *ecdt_ptr;
45bea155 994
d66d969d
AS
995 boot_ec = make_acpi_ec();
996 if (!boot_ec)
c0900c35
AS
997 return -ENOMEM;
998 /*
999 * Generate a boot ec context
1000 */
0adf3c74 1001 dmi_check_system(ec_dmi_table);
15a58ed1
AS
1002 status = acpi_get_table(ACPI_SIG_ECDT, 1,
1003 (struct acpi_table_header **)&ecdt_ptr);
cd8c93a4 1004 if (ACPI_SUCCESS(status)) {
3ebe08a7 1005 pr_info(PREFIX "EC description table is found, configuring boot EC\n");
cd8c93a4
AS
1006 boot_ec->command_addr = ecdt_ptr->control.address;
1007 boot_ec->data_addr = ecdt_ptr->data.address;
1008 boot_ec->gpe = ecdt_ptr->gpe;
4af8e10a 1009 boot_ec->handle = ACPI_ROOT_OBJECT;
ce52ddf5 1010 acpi_get_handle(ACPI_ROOT_OBJECT, ecdt_ptr->id, &boot_ec->handle);
c6cb0e87 1011 /* Don't trust ECDT, which comes from ASUSTek */
0adf3c74 1012 if (!EC_FLAGS_VALIDATE_ECDT)
c5279dee 1013 goto install;
d6bd535d 1014 saved_ec = kmemdup(boot_ec, sizeof(struct acpi_ec), GFP_KERNEL);
c6cb0e87
AS
1015 if (!saved_ec)
1016 return -ENOMEM;
c5279dee 1017 /* fall through */
cd8c93a4 1018 }
0adf3c74 1019
478fa03b
AS
1020 if (EC_FLAGS_SKIP_DSDT_SCAN)
1021 return -ENODEV;
1022
c5279dee
AS
1023 /* This workaround is needed only on some broken machines,
1024 * which require early EC, but fail to provide ECDT */
c5279dee
AS
1025 printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
1026 status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
1027 boot_ec, NULL);
1028 /* Check that acpi_get_devices actually find something */
1029 if (ACPI_FAILURE(status) || !boot_ec->handle)
1030 goto error;
c6cb0e87
AS
1031 if (saved_ec) {
1032 /* try to find good ECDT from ASUSTek */
1033 if (saved_ec->command_addr != boot_ec->command_addr ||
1034 saved_ec->data_addr != boot_ec->data_addr ||
1035 saved_ec->gpe != boot_ec->gpe ||
1036 saved_ec->handle != boot_ec->handle)
1037 pr_info(PREFIX "ASUSTek keeps feeding us with broken "
1038 "ECDT tables, which are very hard to workaround. "
1039 "Trying to use DSDT EC info instead. Please send "
1040 "output of acpidump to linux-acpi@vger.kernel.org\n");
1041 kfree(saved_ec);
1042 saved_ec = NULL;
1043 } else {
1044 /* We really need to limit this workaround, the only ASUS,
1045 * which needs it, has fake EC._INI method, so use it as flag.
1046 * Keep boot_ec struct as it will be needed soon.
1047 */
1048 acpi_handle dummy;
1049 if (!dmi_name_in_vendors("ASUS") ||
1050 ACPI_FAILURE(acpi_get_handle(boot_ec->handle, "_INI",
1051 &dummy)))
1052 return -ENODEV;
1053 }
c5279dee
AS
1054install:
1055 if (!ec_install_handlers(boot_ec)) {
d033879c 1056 first_ec = boot_ec;
e8284321 1057 return 0;
d033879c 1058 }
c5279dee 1059error:
d66d969d
AS
1060 kfree(boot_ec);
1061 boot_ec = NULL;
1da177e4
LT
1062 return -ENODEV;
1063}
1064
223883b7
AS
1065static struct acpi_driver acpi_ec_driver = {
1066 .name = "ec",
1067 .class = ACPI_EC_CLASS,
1068 .ids = ec_device_ids,
1069 .ops = {
1070 .add = acpi_ec_add,
1071 .remove = acpi_ec_remove,
223883b7
AS
1072 },
1073};
1074
a5f820fe 1075int __init acpi_ec_init(void)
1da177e4 1076{
50526df6 1077 int result = 0;
1da177e4 1078
1da177e4
LT
1079 /* Now register the driver for the EC */
1080 result = acpi_bus_register_driver(&acpi_ec_driver);
49c6c5ff 1081 if (result < 0)
d550d98d 1082 return -ENODEV;
1da177e4 1083
d550d98d 1084 return result;
1da177e4
LT
1085}
1086
1da177e4
LT
1087/* EC driver currently not unloadable */
1088#if 0
50526df6 1089static void __exit acpi_ec_exit(void)
1da177e4 1090{
1da177e4
LT
1091
1092 acpi_bus_unregister_driver(&acpi_ec_driver);
d550d98d 1093 return;
1da177e4 1094}
7843932a 1095#endif /* 0 */