mpssd: fix buffer overflow warning
authorMike Danese <mikedanese@google.com>
Fri, 20 May 2016 04:54:51 +0000 (21:54 -0700)
committerJonathan Corbet <corbet@lwn.net>
Fri, 3 Jun 2016 19:31:37 +0000 (13:31 -0600)
The compilation emits a warning in function ‘snprintf’,
    inlined from ‘set_cmdline’ at
    ../Documentation/mic/mpssd/mpssd.c:1541:9:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
    warning: call to __builtin___snprintf_chk will always overflow
    destination buffer

This was introduced in commit f4a66c204482 ("misc: mic: Update MIC host
daemon with COSM changes") and is fixed by reverting the changes to the
size argument of these snprintf statements.

Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Mike Danese <mikedanese@google.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Documentation/mic/mpssd/mpssd.c

index 30fb842a976d3ed3b9b9e1cb0bf5e1f64640dcc4..49db1def1721cdedc09b6a4e459b1cd41f82a749 100644 (file)
@@ -1538,9 +1538,9 @@ set_cmdline(struct mic_info *mic)
 
        len = snprintf(buffer, PATH_MAX,
                "clocksource=tsc highres=off nohz=off ");
-       len += snprintf(buffer + len, PATH_MAX,
+       len += snprintf(buffer + len, PATH_MAX - len,
                "cpufreq_on;corec6_off;pc3_off;pc6_off ");
-       len += snprintf(buffer + len, PATH_MAX,
+       len += snprintf(buffer + len, PATH_MAX - len,
                "ifcfg=static;address,172.31.%d.1;netmask,255.255.255.0",
                mic->id + 1);